Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 448743002: DevTools: Linkify console stacks with blackboxing consideration. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Linkify console stacks with blackboxing consideration. BUG=267592 R=vsevik, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179826

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed #

Patch Set 3 : addressed #

Total comments: 2

Patch Set 4 : addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/networkLogView.css View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/Linkifier.js View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aandrey
the screenshot was attached to the bug
6 years, 4 months ago (2014-08-06 15:54:57 UTC) #1
vsevik
https://codereview.chromium.org/448743002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js File Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/448743002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode201 Source/devtools/front_end/console/ConsoleViewMessage.js:201: this._anchorElement = this._linkifier.linkifyTopUnblackboxedConsoleCallFrame(this._target(), consoleMessage.stackTrace, "console-message-url", true); I don't think ...
6 years, 4 months ago (2014-08-07 09:11:58 UTC) #2
aandrey
PTAL https://codereview.chromium.org/448743002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js File Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/448743002/diff/1/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode201 Source/devtools/front_end/console/ConsoleViewMessage.js:201: this._anchorElement = this._linkifier.linkifyTopUnblackboxedConsoleCallFrame(this._target(), consoleMessage.stackTrace, "console-message-url", true); On 2014/08/07 ...
6 years, 4 months ago (2014-08-07 10:24:59 UTC) #3
aandrey
Now skipping blackboxed call frames to linkify a stack trace only for ConsoleAPI messages. PTAL.
6 years, 4 months ago (2014-08-07 14:32:56 UTC) #4
vsevik
lgtm https://codereview.chromium.org/448743002/diff/40001/Source/devtools/front_end/console/ConsoleViewMessage.js File Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/448743002/diff/40001/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode291 Source/devtools/front_end/console/ConsoleViewMessage.js:291: _callFrameAnchorFromStackTrace: function(stackTrace, isConsoleAPI) I would call this flag ...
6 years, 4 months ago (2014-08-08 08:55:50 UTC) #5
aandrey
https://codereview.chromium.org/448743002/diff/40001/Source/devtools/front_end/console/ConsoleViewMessage.js File Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/448743002/diff/40001/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode291 Source/devtools/front_end/console/ConsoleViewMessage.js:291: _callFrameAnchorFromStackTrace: function(stackTrace, isConsoleAPI) On 2014/08/08 08:55:50, vsevik wrote: > ...
6 years, 4 months ago (2014-08-08 10:05:56 UTC) #6
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-08 10:06:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/448743002/60001
6 years, 4 months ago (2014-08-08 10:07:24 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-08 11:51:42 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 12:25:05 UTC) #10
Message was sent while issue was closed. 
Change committed as 179826

Powered by Google App Engine
This is Rietveld 408576698