Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: Source/devtools/front_end/sdk/Linkifier.js

Issue 448743002: DevTools: Linkify console stacks with blackboxing consideration. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/networkLogView.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/Linkifier.js
diff --git a/Source/devtools/front_end/sdk/Linkifier.js b/Source/devtools/front_end/sdk/Linkifier.js
index ecdebf434ca64d75ad6cec3b3787c059c351aeee..ccc84012a3880a96892c20a579d98e366587ef99 100644
--- a/Source/devtools/front_end/sdk/Linkifier.js
+++ b/Source/devtools/front_end/sdk/Linkifier.js
@@ -159,7 +159,7 @@ WebInspector.Linkifier.prototype = {
var anchor = this._createAnchor(classes);
var liveLocation = WebInspector.debuggerWorkspaceBinding.createLiveLocation(rawLocation, this._updateAnchor.bind(this, anchor));
- this._liveLocationsByTarget.get(rawLocation.target()).push({anchor: anchor, location: liveLocation});
+ this._liveLocationsByTarget.get(rawLocation.target()).push({ anchor: anchor, location: liveLocation });
anchor.__fallbackAnchor = fallbackAnchor;
return anchor;
},
@@ -186,7 +186,10 @@ WebInspector.Linkifier.prototype = {
// FIXME(62725): console stack trace line/column numbers are one-based.
var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
- return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, classes);
+ var anchor = this.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, classes);
+ if (WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled() && WebInspector.BlackboxSupport.isBlackboxedURL(callFrame.url))
+ anchor.classList.add("webkit-html-blackbox-link");
+ return anchor;
},
/**
@@ -200,7 +203,7 @@ WebInspector.Linkifier.prototype = {
var liveLocation = WebInspector.cssWorkspaceBinding.createLiveLocation(rawLocation, this._updateAnchor.bind(this, anchor));
if (!liveLocation)
return null;
- this._liveLocationsByTarget.get(rawLocation.target()).push({anchor: anchor, location: liveLocation});
+ this._liveLocationsByTarget.get(rawLocation.target()).push({ anchor: anchor, location: liveLocation });
return anchor;
},
« no previous file with comments | « Source/devtools/front_end/networkLogView.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698