Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 448713002: Revert of Make SingleThreadProxy a SchedulerClient (Closed)

Created:
6 years, 4 months ago by Sami
Modified:
6 years, 4 months ago
CC:
cc-bugs_chromium.org, ccameron, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, joi+watch-content_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, no sievers, Mr4D (OOO till 08-26), Ian Vollick
Visibility:
Public.

Description

Revert of Make SingleThreadProxy a SchedulerClient (https://codereview.chromium.org/134623005/) Reason for revert: Looks like this made cc_perftests hang on all platforms :( http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/builds/2652 http://build.chromium.org/p/chromium.perf/builders/Mac%2010.9%20Perf%20%282%29/builds/3634 http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%282%29/builds/15378 TBR=enne@chromium.org Original issue's description: > Make SingleThreadProxy a SchedulerClient > > This makes ui::Compositor no longer in charge of > scheduling commits and draws, deferring it to cc::Scheduler. > > Other compositors that use SingleThreadProxy are left calling composite > synchronously and now pass a flag to indicate that this is their > intention. This patch doesn't remove synchronous composite, but now > makes it mutually exclusive with scheduling. > > BUG=329552, 287250 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -592 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/scheduler/scheduler.cc View 9 chunks +12 lines, -15 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 4 chunks +6 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 5 chunks +46 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_single_thread_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 6 chunks +3 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 10 chunks +47 lines, -35 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 7 chunks +7 lines, -39 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 16 chunks +81 lines, -286 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 5 chunks +9 lines, -17 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 5 chunks +24 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 8 chunks +107 lines, -28 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 9 chunks +17 lines, -23 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 2 chunks +3 lines, -12 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.cc View 2 chunks +12 lines, -21 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 14 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sami
Created Revert of Make SingleThreadProxy a SchedulerClient
6 years, 4 months ago (2014-08-06 15:02:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/448713002/1
6 years, 4 months ago (2014-08-06 15:03:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 15:03:20 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-06 15:03:21 UTC) #4
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 4 months ago (2014-08-06 15:03:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/448713002/1
6 years, 4 months ago (2014-08-06 15:05:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-06 15:15:41 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 15:17:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/38020) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/3036) ios_rel_device ...
6 years, 4 months ago (2014-08-06 15:17:40 UTC) #9
Sami
Looks like Tommi got there first: https://codereview.chromium.org/441343002
6 years, 4 months ago (2014-08-06 15:30:05 UTC) #10
Sami
6 years, 4 months ago (2014-08-06 15:42:35 UTC) #11
Message was sent while issue was closed.
FYI, potentially one more affected test here:
http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%285%29/b...

Powered by Google App Engine
This is Rietveld 408576698