Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 441343002: Revert 287747 "Make SingleThreadProxy a SchedulerClient" (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme
Modified:
6 years, 4 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 287747 "Make SingleThreadProxy a SchedulerClient" This is a speculative revert to see if issues on Mac bots get resolved. BrowserTest.WindowOpenClose is e.g. failing on this assert: ASSERTION FAILED: !active || m_layerTreeView > Make SingleThreadProxy a SchedulerClient > > This makes ui::Compositor no longer in charge of > scheduling commits and draws, deferring it to cc::Scheduler. > > Other compositors that use SingleThreadProxy are left calling composite > synchronously and now pass a flag to indicate that this is their > intention. This patch doesn't remove synchronous composite, but now > makes it mutually exclusive with scheduling. > > BUG=329552, 287250 > > Review URL: https://codereview.chromium.org/134623005 TBR=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -572 lines) Patch
M trunk/src/android_webview/browser/hardware_renderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/android_webview/browser/hardware_renderer.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler.cc View 9 chunks +12 lines, -15 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/cc/test/fake_layer_tree_host_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/cc/test/layer_tree_test.h View 4 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/cc/test/layer_tree_test.cc View 5 chunks +46 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_single_thread_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest.cc View 6 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_animation.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_context.cc View 10 chunks +46 lines, -34 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_no_message_loop.cc View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.h View 7 chunks +7 lines, -39 lines 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.cc View 16 chunks +68 lines, -273 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/compositor_impl_android.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/gpu/render_widget_compositor.h View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/gpu/render_widget_compositor.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/render_widget.h View 3 chunks +1 line, -6 lines 0 comments Download
M trunk/src/content/renderer/render_widget.cc View 5 chunks +9 lines, -17 lines 0 comments Download
M trunk/src/content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/ui/compositor/compositor.h View 5 chunks +24 lines, -0 lines 0 comments Download
M trunk/src/ui/compositor/compositor.cc View 8 chunks +103 lines, -24 lines 0 comments Download
M trunk/src/ui/compositor/layer_unittest.cc View 9 chunks +17 lines, -23 lines 0 comments Download
M trunk/src/ui/compositor/test/draw_waiter_for_test.h View 2 chunks +3 lines, -12 lines 0 comments Download
M trunk/src/ui/compositor/test/draw_waiter_for_test.cc View 2 chunks +10 lines, -19 lines 0 comments Download
M trunk/src/ui/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/compositor/test/test_compositor_host_ozone.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/ui/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/compositor/test/test_compositor_host_x11.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/ui/views/view_unittest.cc View 14 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-06 13:05:15 UTC) #1
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-06 13:05:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287766 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698