Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 448643002: Reland "Implement trigonometric functions using a fdlibm port." (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Implement trigonometric functions using a fdlibm port." R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22923

Patch Set 1 #

Patch Set 2 : fix windows build and gc mole #

Unified diffs Side-by-side diffs Delta from patch set Stats (+840 lines, -314 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +11 lines, -35 lines 0 comments Download
M src/math.js View 17 chunks +4 lines, -107 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download
D src/trig-table.h View 1 chunk +0 lines, -38 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mirror-script.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/rempio2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/sin-cos.js View 2 chunks +95 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -7 lines 0 comments Download
A third_party/fdlibm/LICENSE View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/fdlibm/README.v8 View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/fdlibm/fdlibm.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/fdlibm/fdlibm.cc View 1 1 chunk +262 lines, -0 lines 0 comments Download
A third_party/fdlibm/fdlibm.js View 1 chunk +356 lines, -0 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +3 lines, -3 lines 0 comments Download
D tools/generate-trig-table.py View 1 chunk +0 lines, -83 lines 0 comments Download
M tools/gyp/v8.gyp View 8 chunks +5 lines, -35 lines 0 comments Download
M tools/js2c.py View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
First patch set is the original CL. Second patch set is the fix.
6 years, 4 months ago (2014-08-06 11:36:30 UTC) #1
Sven Panne
lgtm
6 years, 4 months ago (2014-08-06 11:39:08 UTC) #2
Yang
6 years, 4 months ago (2014-08-06 11:39:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698