| Index: PRESUBMIT.py
|
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
| index 72aa2484806a446c78d142089b436148c76ae705..f43916a6d208c4505b63e88d26d534116601fb5a 100644
|
| --- a/PRESUBMIT.py
|
| +++ b/PRESUBMIT.py
|
| @@ -143,6 +143,28 @@ _BANNED_OBJC_FUNCTIONS = (
|
| ),
|
| True,
|
| ),
|
| + (
|
| + # This is a C++ function, but it returns an NSObject so is only likely
|
| + # to appear in .mm files.
|
| + 'SkColorToCalibratedNSColor',
|
| + (
|
| + '"Calibrated" colors are probably not what you want. Consider using',
|
| + 'SkColorToSRGBNSColor instead of SkColorToCalibratedNSColor.',
|
| + 'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts',
|
| + ),
|
| + False,
|
| + ),
|
| + (
|
| + # Catch all of [NSColor colorWithCalibrated(Hue|Red|White).*.
|
| + 'colorWithCalibrated',
|
| + (
|
| + '"Calibrated" colors are probably not what you want. Consider using',
|
| + 'the +[NSColor colorWithSRGBRed:green:blue:alpha: or the ',
|
| + '+[NSColor colorWithGenericGamma22White:alpha: method.',
|
| + 'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts',
|
| + ),
|
| + False,
|
| + ),
|
| )
|
|
|
|
|
|
|