[Mac] Check for colour constants that do not specify a colourspace.

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 125 matching lines @@
     ),
     (
       'convertSizeToBase:',
       (
        'The use of -[NSView convertSizeToBase:] is almost certainly wrong.',
        'Please use |convertSize:(point) toView:nil| instead.',
        'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts',
       ),
       True,
     ),
+    (
+      # This is a C++ function, but it returns an NSObject so is only likely
+      # to appear in .mm files.
+      'SkColorToCalibratedNSColor',
+      (
+       '"Calibrated" colors are probably not what you want. Consider using',
+       'SkColorToSRGBNSColor instead of SkColorToCalibratedNSColor.',
+       'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts',
+      ),
+      False,
+    ),
+    (
+      # Catch all of [NSColor colorWithCalibrated(Hue|Red|White).*.
+      'colorWithCalibrated',
+      (
+       '"Calibrated" colors are probably not what you want. Consider using',
+       'the +[NSColor colorWithSRGBRed:green:blue:alpha: or the ',
+       '+[NSColor colorWithGenericGamma22White:alpha: method.',
+       'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts',
+      ),
+      False,
+    ),
 )
 
 
 _BANNED_CPP_FUNCTIONS = (
     # Make sure that gtest's FRIEND_TEST() macro is not used; the
     # FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be
     # used instead since that allows for FLAKY_ and DISABLED_ prefixes.
     (
       'FRIEND_TEST(',
       (
@@ skipping 1465 matching lines @@
     builders.extend(['cros_x86'])
 
   # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
   # unless they're .gyp(i) files as changes to those files can break the gyp
   # step on that bot.
   if (not all(re.search('^chrome', f) for f in files) or
       any(re.search('\.gypi?$', f) for f in files)):
     builders.extend(['android_aosp'])
 
   return GetDefaultTryConfigs(builders)