Issue 448243003: Revert of Process Statistics header, add max RSS to render_pdfs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 448243003: Revert of Process Statistics header, add max RSS to render_pdfs (Closed)

Created:
6 years, 4 months ago by bungeman-skia

Modified:
6 years, 4 months ago

Reviewers:
hal.canary, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Process Statistics header, add max RSS to render_pdfs (https://codereview.chromium.org/448993003/) Reason for revert: Reverting due to breaking iOS bots. Original issue's description: > Process Statistics header, add max RSS to render_pdfs > > Committed: https://skia.googlesource.com/skia/+/6274baae7fe82ce6481da367687aa6168356e1e1 TBR=mtklein@google.com,halcanary@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/619e07656dc51bc252324dbf2579125c5b488b01

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -82 lines)			Patch
M	dm/DMReporter.cpp	View	2 chunks	+17 lines, -4 lines	0 comments	Download
M	gyp/dm.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/tools.gyp	View	2 chunks	+0 lines, -12 lines	0 comments	Download
D	tools/ProcStats.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	tools/ProcStats.cpp	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	tools/render_pdfs_main.cpp	View	3 chunks	+1 line, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of Process Statistics header, add max RSS to render_pdfs

6 years, 4 months ago (2014-08-07 20:25:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/448243003/1

6 years, 4 months ago (2014-08-07 20:26:39 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-07 20:27:27 UTC) #3

Message was sent while issue was closed.

Change committed as 619e07656dc51bc252324dbf2579125c5b488b01