Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 448223002: Only switch draw buffers if the extension is supported (Closed)

Created:
6 years, 4 months ago by oetuaho-nv
Modified:
6 years, 4 months ago
Reviewers:
Zhenyao Mo, ccameron
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Only switch draw buffers if the extension is supported Otherwise it's possible to end up crashing when calling a null function pointer, if a framebuffer does not have a color buffer attached. This bug applies to at least some GLES3 platforms, where DrawBuffers function is not bound (which is reasonable, since core version of the function behaves subtly differently than DrawBuffersEXT in relation to GLSL ES 1.0 shaders, if the EXT_draw_buffers extension is missing). Also possibly GLES2 platforms which implement OES_depth_texture but not EXT_draw_buffers. BUG=401645 TEST=gpu_unittests, WebGL conformance tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oetuaho-nv
Looks like issue in https://codereview.chromium.org/375413003 was never properly addressed once the commit was reverted. Please ...
6 years, 4 months ago (2014-08-07 19:15:06 UTC) #1
Zhenyao Mo
LGTM Thank you for pushing this through.
6 years, 4 months ago (2014-08-07 20:32:37 UTC) #2
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 4 months ago (2014-08-08 07:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/448223002/1
6 years, 4 months ago (2014-08-08 07:04:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-08 11:32:00 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 14:02:58 UTC) #6
Message was sent while issue was closed.
Change committed as 288347

Powered by Google App Engine
This is Rietveld 408576698