Issue 375413003: Do not call glDrawBuffersARB when the extension is absent

Issue 375413003: Do not call glDrawBuffersARB when the extension is absent (Closed)

Created:
6 years, 5 months ago by ccameron

Modified:
6 years, 5 months ago

Reviewers:
Zhenyao Mo, bajones, scherkus (not reviewing)

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not call glDrawBuffersARB when the extension is absent The function Framebuffer::ChangeDrawBuffersHelper was assuming that binding of an FBO with no GL_COLOR_ATTACHMENT0 was accompanied by setting the first draw buffer to GL_NONE with glDrawBuffersARB in the fix introduced in: https://codereview.chromium.org/315283002 When the extension is not present, it can be assumed that the glDrawBuffersARB state need not be set and restored. BUG=(wrangling) NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282393

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	gpu/command_buffer/service/framebuffer_manager.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

ccameron

Oh, huh -- looks like https://codereview.chromium.org/379623002/ fixed it.

6 years, 5 months ago (2014-07-09 20:28:07 UTC) #2

Zhenyao Mo

LGTM Yes, we should still land this, even though the path is not exercised at ...

6 years, 5 months ago (2014-07-10 16:33:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/375413003/1

6 years, 5 months ago (2014-07-10 19:21:35 UTC) #6

scherkus (not reviewing)

FYI this broke gpu_unittests on the main waterfall: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%20LSan%20Tests%20%281%29&number=3858 http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Ozone%20Tests%20%281%29&number=108 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=25228

6 years, 5 months ago (2014-07-10 19:51:31 UTC) #8

ccameron

6 years, 5 months ago (2014-07-10 20:00:38 UTC) #9

Message was sent while issue was closed.

On 2014/07/10 19:51:31, scherkus wrote:
> FYI this broke gpu_unittests on the main waterfall:
>
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%...
>
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...
>
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tes...

Drr... I left the NOTRY in there from when this was to green up the GPU
waterfall (oops).

Expand Messages | Collapse Messages