Issue 448193002: Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a

Issue 448193002: Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin

Modified:
6 years, 4 months ago

Reviewers:
Marijn Kruisselbrink

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a std::string. R=mek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288156

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -15 lines)			Patch
M	chrome/browser/extensions/sandboxed_unpacker.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	extensions/browser/extension_icon_image.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	extensions/common/extension_icon_set.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/extension_icon_set.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	extensions/common/manifest_handlers/icons_handler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

not at google - send to devlin

The CQ bit was checked by kalman@chromium.org

6 years, 4 months ago (2014-08-07 16:58:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/448193002/1

6 years, 4 months ago (2014-08-07 17:01:49 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...

6 years, 4 months ago (2014-08-07 18:36:17 UTC) #5

Message was sent while issue was closed.

Change committed as 288156