extensions/common/extension_icon_set.h - Issue 448193002: Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_icon_set.h

Issue 448193002: Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/extension_icon_set.h

diff --git a/extensions/common/extension_icon_set.h b/extensions/common/extension_icon_set.h

index 6a7697bb259148e897140b3ca99cb085b2c004b3..2791db20ab461d57b0f1e13c1640c9b7b031b658 100644

--- a/extensions/common/extension_icon_set.h

+++ b/extensions/common/extension_icon_set.h

@@ -37,7 +37,7 @@ class ExtensionIconSet {

// Gets path value of the icon found when searching for |size| using

// |mathc_type|.

- std::string Get(int size, MatchType match_type) const;

+ const std::string& Get(int size, MatchType match_type) const;

// Returns true iff the set contains the specified path.

bool ContainsPath(const std::string& path) const;

« no previous file with comments | « extensions/browser/extension_icon_image.cc ('k') | extensions/common/extension_icon_set.cc » ('j') | no next file with comments »