Remove unused RenderPassDrawQuad fields

Remove unused RenderPassDrawQuad fields

The contents_changed_since_last_frame and is_replica fields are not
used. Also removes RenderSurfaceImpl's ContentsChanged() as this method
was only used in determining the value of
contents_changed_since_last_frame.

Unfortunately now RenderPassDrawQuad is only the largest quad type on
64-bit builds. So, adds kLargestQuadType to cc/quads/ and moves the
largest-quad-type unit test there verifying that kLargestQuadType is
the largest now, instead of RenderPassDrawQuad.

R=enne
BUG=401481
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289091

[danakj, 2014-08-07 13:32:30]

+tsepez IPC review, removing a field.

[enne (OOO), 2014-08-07 17:03:56]

lgtm

[Tom Sepez, 2014-08-07 17:09:10]

Rubberstamp LGTM on deleting field.

[danakj, 2014-08-08 01:34:03]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-08 01:40:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/1

[commit-bot: I haz the power, 2014-08-08 06:24:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[commit-bot: I haz the power, 2014-08-08 06:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 06:57:55]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2014-08-08 13:32:17]

Fun times!

RenderPassDrawQuad is no longer the largest quad type... on 32 bit builds...

[danakj, 2014-08-08 15:05:19]

enne: PTAL

Turns out RPDQ::is_replica is not used either, so I removed that too.

To make this work across platforms, I've added a kLargestDrawQuad type, which is
either RPDQ or PictureDQ depending on 32 or 64 bit build, and moved the unit
test verifying the largest quad type to cc/quads/

[danakj, 2014-08-08 15:09:56]

tsepez: there's a new change in cc_messages.cc if you can look please. I've
replaced sizeof(RenderPassDrawQuad) with sizeof(kLargestDrawQuad) since it
differs on 32 and 64 bit platforms now. The unit test moved but now verifies
that kLargestDrawQuad is the largest instead of verifying RenderPassDrawQuad is.

[enne (OOO), 2014-08-08 17:01:17]

lgtm

[Tom Sepez, 2014-08-08 17:41:11]

LGTM with comment.

https://codereview.chromium.org/448133002/diff/40001/content/common/cc_messag...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/448133002/diff/40001/content/common/cc_messag...
content/common/cc_messages.cc:392: to_reserve += p.quad_list.size() *
sizeof(cc::kLargestDrawQuad);
nit: down the road, I'd like to see these size computations move to
base::internal::CheckedNumeric<size_t> to avoid the possibility of overflow on
32-bit platforms. This is mitigated by the need to already have a quad_list of
significant size in order to hit the overflow, and it may be hard to arrange for
that ...

[danakj, 2014-08-08 19:52:04]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:53:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/100001

[danakj, 2014-08-08 19:53:13]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:55:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/120001

[commit-bot: I haz the power, 2014-08-09 04:08:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-09 10:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-09 10:11:10]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2014-08-10 12:21:59]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-10 12:23:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/120001

[commit-bot: I haz the power, 2014-08-10 12:26:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-10 12:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-10 12:28:46]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2014-08-10 12:53:47]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-10 12:54:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/120001

[commit-bot: I haz the power, 2014-08-10 12:57:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-10 12:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-10 12:59:35]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2014-08-10 14:43:32]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-10 14:44:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/120001

[commit-bot: I haz the power, 2014-08-10 14:48:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-10 14:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-10 14:51:05]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2014-08-11 13:49:20]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-08-11 13:49:21]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-08-11 14:43:37]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-11 14:44:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/140001

[commit-bot: I haz the power, 2014-08-12 02:52:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-12 04:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 04:33:35]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2014-08-12 16:39:57]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-12 16:42:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/200001

[danakj, 2014-08-12 16:43:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-12 16:46:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/220001

[danakj, 2014-08-12 16:48:51]

https://codereview.chromium.org/448133002/diff/40001/content/common/cc_messag...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/448133002/diff/40001/content/common/cc_messag...
content/common/cc_messages.cc:392: to_reserve += p.quad_list.size() *
sizeof(cc::kLargestDrawQuad);
On 2014/08/08 17:41:11, Tom Sepez wrote:
> nit: down the road, I'd like to see these size computations move to
> base::internal::CheckedNumeric<size_t> to avoid the possibility of overflow on
> 32-bit platforms. This is mitigated by the need to already have a quad_list of
> significant size in order to hit the overflow, and it may be hard to arrange
for
> that ...

BTW, An overflow here would be on the renderer side, and would result in only a
performance loss as the reserved memory would be too small, and the IPC buffer
would have to be enlarged as each element is written to it.

[danakj, 2014-08-12 21:55:16]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-08-12 21:55:26]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-12 22:03:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/448133002/220001

[commit-bot: I haz the power, 2014-08-12 22:41:23]

Change committed as 289091