Remove unused RenderPassDrawQuad fields

content/common/cc_messages.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/cc_messages.h"
 
 #include "cc/output/compositor_frame.h"
 #include "cc/output/filter_operations.h"
+#include "cc/quads/largest_draw_quad.h"
 #include "content/public/common/common_param_traits.h"
 #include "third_party/skia/include/core/SkData.h"
 #include "third_party/skia/include/core/SkFlattenableSerialization.h"
 #include "ui/gfx/transform.h"
 
 namespace IPC {
 
 void ParamTraits<cc::FilterOperation>::Write(
     Message* m, const param_type& p) {
   WriteParam(m, p.type());
@@ skipping 362 matching lines @@
 
 static size_t ReserveSizeForRenderPassWrite(const cc::RenderPass& p) {
   size_t to_reserve = sizeof(cc::RenderPass);
 
   to_reserve += p.shared_quad_state_list.size() * sizeof(cc::SharedQuadState);
 
   // The shared_quad_state_index for each quad.
   to_reserve += p.quad_list.size() * sizeof(size_t);
 
   // The largest quad type, verified by a unit test.
-  to_reserve += p.quad_list.size() * sizeof(cc::RenderPassDrawQuad);
+  to_reserve += p.quad_list.size() * sizeof(cc::kLargestDrawQuad);

[Tom Sepez, 2014/08/08 17:41:11]

nit: down the road, I'd like to see these size computations move to
base::internal::CheckedNumeric<size_t> to avoid the possibility of overflow on
32-bit platforms. This is mitigated by the need to already have a quad_list of
significant size in order to hit the overflow, and it may be hard to arrange for
that ...

[danakj, 2014/08/12 16:48:51]

BTW, An overflow here would be on the renderer side, and would result in only a
performance loss as the reserved memory would be too small, and the IPC buffer
would have to be enlarged as each element is written to it.

   return to_reserve;
 }
 
 template<typename QuadType>
 static scoped_ptr<cc::DrawQuad> ReadDrawQuad(const Message* m,
                                              PickleIterator* iter) {
   scoped_ptr<QuadType> quad(new QuadType);
   if (!ReadParam(m, iter, quad.get()))
     return scoped_ptr<QuadType>().template PassAs<cc::DrawQuad>();
   return quad.template PassAs<cc::DrawQuad>();
@@ skipping 392 matching lines @@
   l->append(", ");
   LogParam(p.size, l);
   l->append(", ");
   LogParam(p.damage_rect, l);
   l->append(", ");
   LogParam(p.bitmap_id, l);
   l->append(")");
 }
 
 }  // namespace IPC