ES6: Implement WeakMap and WeakSet constructor logic

ES6: Implement WeakMap and WeakSet constructor logic

Now that iterators are enabled by default we need to correctly
handle the parameter for WeakMap and WeakSet. If provided then the
argument is iterated over to add entries to the WeakMap and WeakSet.

BUG=v8:3399
LOG=Y
R=adamk@chromium.org, rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22999

[arv (Not doing code reviews), 2014-08-07 20:09:51]

PTAL

[adamk, 2014-08-07 20:20:09]

non-OWNER lgtm

[rossberg, 2014-08-08 11:24:05]

LGTM, modulo one additional test.

https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections.js
File test/mjsunit/es6/collections.js (right):

https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections...
test/mjsunit/es6/collections.js:1026: // @@iterator result not object
Exclusively for weak maps and sets, we should also have a test where the
iterator returns some r where r.value is not an object (i.e., not a legal key
for weak collections).

[rossberg, 2014-08-08 13:39:21]

Committed patchset #1 manually as 22999 (presubmit successful).

[rossberg, 2014-08-08 13:40:17]

On 2014/08/08 11:24:05, rossberg wrote:
> LGTM, modulo one additional test.
> 
>
https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections.js
> File test/mjsunit/es6/collections.js (right):
> 
>
https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections...
> test/mjsunit/es6/collections.js:1026: // @@iterator result not object
> Exclusively for weak maps and sets, we should also have a test where the
> iterator returns some r where r.value is not an object (i.e., not a legal key
> for weak collections).

I landed it anyway, to sneak it into M38. But I'd appreciate if you could add
these tiny tests in a follow-up CL.

[arv (Not doing code reviews), 2014-08-08 15:13:20]

On 2014/08/08 at 13:40:17, rossberg wrote:
> On 2014/08/08 11:24:05, rossberg wrote:
> > LGTM, modulo one additional test.
> > 
> >
https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections.js
> > File test/mjsunit/es6/collections.js (right):
> > 
> >
https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections...
> > test/mjsunit/es6/collections.js:1026: // @@iterator result not object
> > Exclusively for weak maps and sets, we should also have a test where the
> > iterator returns some r where r.value is not an object (i.e., not a legal
key
> > for weak collections).
> 
> I landed it anyway, to sneak it into M38. But I'd appreciate if you could add
these tiny tests in a follow-up CL.

Thanks. Follow up CL with tests: https://codereview.chromium.org/451033003