Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 451033003: WeakMap/WeakSet: Add test for non object keys (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

WeakMap/WeakSet: Add test for non object keys Add test for non object keys in the iterable passed to the constructor. BUG=v8:3399 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M test/mjsunit/es6/collections.js View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Followup to https://codereview.chromium.org/448013005/
6 years, 4 months ago (2014-08-08 15:13:05 UTC) #1
rossberg
lgtm
6 years, 4 months ago (2014-08-08 15:34:20 UTC) #2
arv (Not doing code reviews)
Thanks. Care to land this for me?
6 years, 4 months ago (2014-08-11 14:42:25 UTC) #3
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-12 19:55:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698