Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 447633002: Forward {Will/Did}StartBrowser calls to page test (Closed)

Created:
6 years, 4 months ago by a.renevier
Modified:
6 years, 4 months ago
Reviewers:
ariblue, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Forward {Will/Did}StartBrowser calls to page test Now, WillStartBrowser method is never called on the benchmark tests. This patch override the stub PageTest.WillStartBrowser in RecorderPageTest. When WillStartBrowser is called, it forwards the call to it's benchmark test. The same behaviour is also applied to DidStartBrowser method R= BUG=400894 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
a.renevier
6 years, 4 months ago (2014-08-05 22:28:55 UTC) #1
ariblue
I've got a very similar patch here: https://codereview.chromium.org/427093002/ that was reverted at the end of ...
6 years, 4 months ago (2014-08-05 23:50:19 UTC) #2
tonyg
lgtm
6 years, 4 months ago (2014-08-06 01:43:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.renevier@samsung.com/447633002/1
6 years, 4 months ago (2014-08-06 01:46:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 06:15:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 08:05:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/3351)
6 years, 4 months ago (2014-08-06 08:05:30 UTC) #7
a.renevier
On 2014/08/06 08:05:30, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-06 19:54:54 UTC) #8
ariblue
The CQ bit was checked by ariblue@google.com
6 years, 4 months ago (2014-08-19 21:09:08 UTC) #9
ariblue
lgtm This should land, the error was likely unrelated.
6 years, 4 months ago (2014-08-19 21:09:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.renevier@samsung.com/447633002/1
6 years, 4 months ago (2014-08-19 21:10:28 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 22:51:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 290684

Powered by Google App Engine
This is Rietveld 408576698