Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 427093002: Add {Will,Did}StartBrowser to record_wpr (Closed)

Created:
6 years, 4 months ago by ariblue
Modified:
6 years, 4 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add {Will,Did}StartBrowser to record_wpr. Needed for PageMeasurements that assume a self._power_metric is created during the WillStartBrowser step. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286744

Patch Set 1 #

Patch Set 2 : add tests + lint fixes #

Patch Set 3 : get rid of broken --browser fix #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 9 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ariblue
6 years, 4 months ago (2014-07-29 20:51:36 UTC) #1
tonyg
lgtm But I do wonder whether a unittest would help this from accidentally breaking due ...
6 years, 4 months ago (2014-07-29 21:26:31 UTC) #2
dtu
lgtm
6 years, 4 months ago (2014-07-29 22:21:27 UTC) #3
ariblue
On 2014/07/29 21:26:31, tonyg wrote: > lgtm > > But I do wonder whether a ...
6 years, 4 months ago (2014-07-29 22:38:07 UTC) #4
ariblue
The CQ bit was checked by ariblue@google.com
6 years, 4 months ago (2014-07-30 18:53:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ariblue@google.com/427093002/60001
6 years, 4 months ago (2014-07-30 18:53:56 UTC) #6
ariblue
On 2014/07/30 18:53:13, ariblue wrote: > The CQ bit was checked by mailto:ariblue@google.com Got rid ...
6 years, 4 months ago (2014-07-30 18:54:18 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-31 01:05:25 UTC) #8
commit-bot: I haz the power
Change committed as 286744
6 years, 4 months ago (2014-07-31 11:54:45 UTC) #9
pneubeck (no reviews)
6 years, 4 months ago (2014-07-31 13:39:43 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/437543002/ by pneubeck@chromium.org.

The reason for reverting is: Broke telemetry unittests.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/1260....

Powered by Google App Engine
This is Rietveld 408576698