Cursor to be centrally aligned instead of top aligned

Cursor to be centrally aligned instead of top aligned

Previous code in r178276, only accounted for font height but padding,
border and box height should be also taken into account.

BUG=400522
R=leviw, esprehn
TEST=Various tests that need rebaseline due to code change.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181000

[Habib Virji, 2014-08-07 12:57:44]

Implement esprehn suggestion. It does fixes the issue and also issue raised in
bug 391215.

[Habib Virji, 2014-08-11 18:37:29]

On 2014/08/07 12:57:44, Habib Virji wrote:
> Implement esprehn suggestion. It does fixes the issue and also issue raised in
> bug 391215.

https://codereview.chromium.org/447243002/

[esprehn, 2014-08-11 20:41:01]

lgtm

[esprehn, 2014-08-11 20:41:31]

Can you add a more specific test instead of just the rebaselines? Those tests
are not very explicit about what this code was for.

[Habib Virji, 2014-08-26 13:20:37]

On 2014/08/11 20:41:31, esprehn wrote:
> Can you add a more specific test instead of just the rebaselines? Those tests
> are not very explicit about what this code was for.

@esprehn: Added new tests, can you please have a look if they are correct. As
found no way of finding align(top or centeR), instead used top and bottom values
to confirm caret position.

[esprehn, 2014-08-27 20:57:33]

lgtm

[Habib Virji, 2014-08-27 21:00:58]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2014-08-27 21:02:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/447243002/140001

[commit-bot: I haz the power, 2014-08-27 21:57:43]

Committed patchset #8 (id:140001) as 181000

[mlamouri (slow - plz ping), 2014-08-28 10:15:24]

A revert of this CL (patchset #8) has been created in
https://codereview.chromium.org/512173002/ by mlamouri@chromium.org.

The reason for reverting is: This is breaking Win XP bots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@To....

[mlamouri (slow - plz ping), 2014-08-28 10:29:26]

LGTM, please reland with NOTRY=true