Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 447183006: Makes --analyzer behave same as --analyzer2 (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Makes --analyzer behave same as --analyzer2 Then I can convert recipes back to --analyzer and finally remove --analyzer2. Oy! BUG=109173 TEST=none R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288360

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M build/gyp_chromium View 1 chunk +2 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
sky
6 years, 4 months ago (2014-08-07 21:34:12 UTC) #1
Nico
https://codereview.chromium.org/447183006/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/447183006/diff/1/build/gyp_chromium#newcode199 build/gyp_chromium:199: args.append('-Ganalyzer_output_path=' + args.pop(0)) lgtm assuming args always has at ...
6 years, 4 months ago (2014-08-07 21:37:10 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-07 21:41:04 UTC) #3
sky
Your assumption is correct.
6 years, 4 months ago (2014-08-07 21:41:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/447183006/1
6 years, 4 months ago (2014-08-07 22:22:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 02:45:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 03:09:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3569)
6 years, 4 months ago (2014-08-08 03:09:18 UTC) #8
sky
6 years, 4 months ago (2014-08-08 14:45:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as 288360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698