Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: build/gyp_chromium

Issue 447183006: Makes --analyzer behave same as --analyzer2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 3c0aa6f7dbb2f56eecfdaaf2eb69e4281e750d3a..00cbf2778dfbd51f831a3921ecc40efb3cf97480 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -190,15 +190,11 @@ if __name__ == '__main__':
args = sys.argv[1:]
# TODO(sky): remove analyzer2 once updated recipes.
- use_analyzer = len(args) and args[0] == '--analyzer'
+ use_analyzer = len(args) and (args[0] == '--analyzer' or
+ args[0] == '--analyzer2')
if use_analyzer:
args.pop(0)
os.environ['GYP_GENERATORS'] = 'analyzer'
- args.append('-Gfile_path=' + args.pop(0))
- elif len(args) and args[0] == '--analyzer2':
- use_analyzer = True
- args.pop(0)
- os.environ['GYP_GENERATORS'] = 'analyzer'
args.append('-Gconfig_path=' + args.pop(0))
args.append('-Ganalyzer_output_path=' + args.pop(0))
Nico 2014/08/07 21:37:09 lgtm assuming args always has at least 2 elements
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698