Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: pkg/analysis_server/test/protocol_test.dart

Issue 446983002: Change the type of Error.code from int to String. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/protocol_test.dart
diff --git a/pkg/analysis_server/test/protocol_test.dart b/pkg/analysis_server/test/protocol_test.dart
index 1e4c4dc70e6a46767eedf698b12f25a4dd11bb9a..3fcabfb2c721e7e0a926c0c5ddf9e24617e01494 100644
--- a/pkg/analysis_server/test/protocol_test.dart
+++ b/pkg/analysis_server/test/protocol_test.dart
@@ -27,7 +27,7 @@ main() {
@ReflectiveTestCase()
class InvalidParameterResponseMatcher extends Matcher {
- static const int ERROR_CODE = -2;
+ static const String ERROR_CODE = 'INVALID_PARAMETER';
@override
Description describe(Description description) => description.add(
@@ -396,11 +396,11 @@ class RequestDatumTest {
@ReflectiveTestCase()
class RequestErrorTest {
void test_create() {
- RequestError error = new RequestError(42, 'msg');
- expect(error.code, 42);
+ RequestError error = new RequestError('ERROR_CODE', 'msg');
+ expect(error.code, 'ERROR_CODE');
expect(error.message, "msg");
expect(error.toJson(), equals({
- RequestError.CODE: 42,
+ RequestError.CODE: 'ERROR_CODE',
RequestError.MESSAGE: "msg"
}));
}
@@ -457,11 +457,11 @@ class RequestErrorTest {
}
void test_toJson() {
- RequestError error = new RequestError(0, 'msg');
+ RequestError error = new RequestError('ERROR_CODE', 'msg');
error.setData('answer', 42);
error.setData('question', 'unknown');
expect(error.toJson(), {
- RequestError.CODE: 0,
+ RequestError.CODE: 'ERROR_CODE',
RequestError.MESSAGE: 'msg',
RequestError.DATA: {
'answer': 42,
@@ -587,7 +587,7 @@ class ResponseTest {
expect(response.toJson(), equals({
Response.ID: '0',
Response.ERROR: {
- 'code': -1,
+ 'code': 'NONEXISTENT_CONTEXT',
'message': 'Context does not exist'
}
}));
@@ -600,7 +600,7 @@ class ResponseTest {
expect(response.toJson(), equals({
Response.ID: '',
Response.ERROR: {
- 'code': -4,
+ 'code': 'INVALID_REQUEST',
'message': 'Invalid request'
}
}));
@@ -614,7 +614,7 @@ class ResponseTest {
expect(response.toJson(), equals({
Response.ID: '0',
Response.ERROR: {
- 'code': -5,
+ 'code': 'MISSING_PARAMETER',
'message': 'Missing required parameter: x'
}
}));
@@ -628,7 +628,7 @@ class ResponseTest {
expect(response.toJson(), equals({
Response.ID: '0',
Response.ERROR: {
- 'code': -11,
+ 'code': 'UNANALYZED_PRIORITY_FILES',
'message': "Unanalyzed files cannot be a priority: 'file list'"
}
}));
@@ -642,7 +642,7 @@ class ResponseTest {
expect(response.toJson(), equals({
Response.ID: '0',
Response.ERROR: {
- 'code': -6,
+ 'code': 'UNKNOWN_ANALYSIS_OPTION',
'message': 'Unknown analysis option: "x"'
}
}));
@@ -655,7 +655,7 @@ class ResponseTest {
expect(response.toJson(), equals({
Response.ID: '0',
Response.ERROR: {
- 'code': -7,
+ 'code': 'UNKNOWN_REQUEST',
'message': 'Unknown request'
}
}));
@@ -673,7 +673,7 @@ class ResponseTest {
expect(response.id, equals(''));
expect(response.error, isNotNull);
RequestError error = response.error;
- expect(error.code, equals(-4));
+ expect(error.code, equals('INVALID_REQUEST'));
expect(error.message, equals('Invalid request'));
}
« no previous file with comments | « pkg/analysis_server/test/integration/protocol_matchers.dart ('k') | pkg/analysis_server/tool/spec/spec_input.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698