Change the type of Error.code from int to String.

pkg/analysis_server/test/protocol_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.protocol;
 
 import 'dart:convert';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_services/json.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 
 Matcher _throwsRequestFailure = throwsA(new isInstanceOf<RequestFailure>());
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(NotificationTest);
   runReflectiveTests(RequestTest);
   runReflectiveTests(RequestErrorTest);
   runReflectiveTests(RequestDatumTest);
   runReflectiveTests(ResponseTest);
 }
 
 
 @ReflectiveTestCase()
 class InvalidParameterResponseMatcher extends Matcher {
-  static const int ERROR_CODE = -2;
+  static const String ERROR_CODE = 'INVALID_PARAMETER';
 
   @override
   Description describe(Description description) => description.add(
       "an 'invalid parameter' response (code $ERROR_CODE)");
 
   @override
   bool matches(item, Map matchState) {
     if (item is! RequestFailure) {
       return false;
     }
@@ skipping 348 matching lines @@
 
   static RequestDatum makeDatum(dynamic datum) {
     return new RequestDatum(request, 'myPath', datum);
   }
 }
 
 
 @ReflectiveTestCase()
 class RequestErrorTest {
   void test_create() {
-    RequestError error = new RequestError(42, 'msg');
-    expect(error.code, 42);
+    RequestError error = new RequestError('ERROR_CODE', 'msg');
+    expect(error.code, 'ERROR_CODE');
     expect(error.message, "msg");
     expect(error.toJson(), equals({
-      RequestError.CODE: 42,
+      RequestError.CODE: 'ERROR_CODE',
       RequestError.MESSAGE: "msg"
     }));
   }
 
   void test_create_internalError() {
     RequestError error = new RequestError.internalError();
     expect(error.code, RequestError.CODE_INTERNAL_ERROR);
     expect(error.message, "Internal error");
   }
 
@@ skipping 36 matching lines @@
       }
     };
     RequestError error = new RequestError.fromJson(json);
     expect(error.code, RequestError.CODE_PARSE_ERROR);
     expect(error.message, "foo");
     expect(error.data['ints'], [1, 2, 3]);
     expect(error.getData('ints'), [1, 2, 3]);
   }
 
   void test_toJson() {
-    RequestError error = new RequestError(0, 'msg');
+    RequestError error = new RequestError('ERROR_CODE', 'msg');
     error.setData('answer', 42);
     error.setData('question', 'unknown');
     expect(error.toJson(), {
-      RequestError.CODE: 0,
+      RequestError.CODE: 'ERROR_CODE',
       RequestError.MESSAGE: 'msg',
       RequestError.DATA: {
         'answer': 42,
         'question': 'unknown'
       }
     });
   }
 }
 
 
@@ skipping 105 matching lines @@
 
 @ReflectiveTestCase()
 class ResponseTest {
   void test_create_contextDoesNotExist() {
     Response response = new Response.contextDoesNotExist(new Request('0', ''));
     expect(response.id, equals('0'));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.ERROR: {
-        'code': -1,
+        'code': 'NONEXISTENT_CONTEXT',
         'message': 'Context does not exist'
       }
     }));
   }
 
   void test_create_invalidRequestFormat() {
     Response response = new Response.invalidRequestFormat();
     expect(response.id, equals(''));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '',
       Response.ERROR: {
-        'code': -4,
+        'code': 'INVALID_REQUEST',
         'message': 'Invalid request'
       }
     }));
   }
 
   void test_create_missingRequiredParameter() {
     Response response = new Response.missingRequiredParameter(new Request('0',
         ''), 'x');
     expect(response.id, equals('0'));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.ERROR: {
-        'code': -5,
+        'code': 'MISSING_PARAMETER',
         'message': 'Missing required parameter: x'
       }
     }));
   }
 
   void test_create_unanalyzedPriorityFiles() {
     Response response = new Response.unanalyzedPriorityFiles(new Request('0',
         ''), 'file list');
     expect(response.id, equals('0'));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.ERROR: {
-        'code': -11,
+        'code': 'UNANALYZED_PRIORITY_FILES',
         'message': "Unanalyzed files cannot be a priority: 'file list'"
       }
     }));
   }
 
   void test_create_unknownAnalysisOption() {
     Response response = new Response.unknownAnalysisOption(new Request('0', ''),
         'x');
     expect(response.id, equals('0'));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.ERROR: {
-        'code': -6,
+        'code': 'UNKNOWN_ANALYSIS_OPTION',
         'message': 'Unknown analysis option: "x"'
       }
     }));
   }
 
   void test_create_unknownRequest() {
     Response response = new Response.unknownRequest(new Request('0', ''));
     expect(response.id, equals('0'));
     expect(response.error, isNotNull);
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.ERROR: {
-        'code': -7,
+        'code': 'UNKNOWN_REQUEST',
         'message': 'Unknown request'
       }
     }));
   }
 
   void test_fromJson() {
     Response original = new Response('myId');
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals('myId'));
   }
 
   void test_fromJson_withError() {
     Response original = new Response.invalidRequestFormat();
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals(''));
     expect(response.error, isNotNull);
     RequestError error = response.error;
-    expect(error.code, equals(-4));
+    expect(error.code, equals('INVALID_REQUEST'));
     expect(error.message, equals('Invalid request'));
   }
 
   void test_fromJson_withResult() {
     Response original = new Response('myId');
     original.setResult('foo', 'bar');
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals('myId'));
     Map<String, Object> result = response.result;
     expect(result.length, equals(1));
     expect(result['foo'], equals('bar'));
   }
 
   void test_setResult() {
     String resultName = 'name';
     String resultValue = 'value';
     Response response = new Response('0');
     response.setResult(resultName, resultValue);
     expect(response.getResult(resultName), same(resultValue));
     expect(response.toJson(), equals({
       Response.ID: '0',
       Response.RESULT: {
         resultName: resultValue
       }
     }));
   }
 }