Issue 446973004: Only escape U+0022 in argument values of `String.prototype` HTML methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 446973004: Only escape U+0022 in argument values of `String.prototype` HTML methods (Closed)

Created:
6 years, 4 months ago by mathias

Modified:
6 years, 4 months ago

Reviewers:
mathiasb, arv (Not doing code reviews), Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Only escape U+0022 in argument values of `String.prototype` HTML methods Contributed by Mathias Bynens <mathiasb@opera.com>;. TEST=mjsunit/es6/string-html BUG=v8:2217 LOG=Y R=arv@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22955

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	src/string.js	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	test/mjsunit/es6/string-html.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

mathiasb

Feel free to close the old patch at https://chromiumcodereview.appspot.com/10693101 (the web UI won’t let me ...

6 years, 4 months ago (2014-08-06 20:27:11 UTC) #1

arv (Not doing code reviews)

LGTM Since I'm not an owner Yang needs to review too.

6 years, 4 months ago (2014-08-06 20:43:58 UTC) #2

Yang

On 2014/08/06 20:43:58, arv wrote: > LGTM > > Since I'm not an owner Yang ...

6 years, 4 months ago (2014-08-07 07:34:27 UTC) #3

Yang

6 years, 4 months ago (2014-08-07 07:45:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 22955 (presubmit successful).