src/string.js - Issue 446973004: Only escape U+0022 in argument values of `String.prototype` HTML methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 446973004: Only escape U+0022 in argument values of `String.prototype` HTML methods (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index 5cd1c0cfb71fc2edbe62b91960af7e2708ce0c43..ae65264d4a3ae2c29cc39add829dd45e51ccf0c3 100644

--- a/src/string.js

+++ b/src/string.js

@@ -829,10 +829,7 @@ function StringFromCharCode(code) {

// ES6 draft, revision 26 (2014-07-18), section B.2.3.2.1

function HtmlEscape(str) {

- return TO_STRING_INLINE(str).replace(/</g, "<")

- .replace(/>/g, ">")

- .replace(/"/g, """)

- .replace(/'/g, "'");

+ return TO_STRING_INLINE(str).replace(/"/g, """);

}

« no previous file with comments | « no previous file | test/mjsunit/es6/string-html.js » ('j') | no next file with comments »