Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 446933003: We should never allocate a 0-sized buffer, so never grow from 0. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

We should never allocate a 0-sized buffer, so never grow from 0. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22947

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Another 0-sized assembler #

Patch Set 4 : Restore 0 as indication that you want kMinimalBufferSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/assembler.cc View 1 2 3 1 chunk +4 lines, -9 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/lithium.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-06 17:32:20 UTC) #1
Igor Sheludko
lgtm
6 years, 4 months ago (2014-08-06 17:47:31 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-06 17:48:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as 22947 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698