src/arm64/assembler-arm64.cc - Issue 446933003: We should never allocate a 0-sized buffer, so never grow from 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/assembler-arm64.cc

Issue 446933003: We should never allocate a 0-sized buffer, so never grow from 0. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Restore 0 as indication that you want kMinimalBufferSize Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/assembler-arm64.cc

diff --git a/src/arm64/assembler-arm64.cc b/src/arm64/assembler-arm64.cc

index a51b22ad9a5789875922002a54bdb28897e9934a..dc2d587f177d1ba3f7653b09ab2aac0448ed8d25 100644

--- a/src/arm64/assembler-arm64.cc

+++ b/src/arm64/assembler-arm64.cc

@@ -2771,9 +2771,7 @@ void Assembler::GrowBuffer() {

// Compute new buffer size.

CodeDesc desc; // the new buffer

- if (buffer_size_ == 0) {

- desc.buffer_size = kMinimalBufferSize;

- } else if (buffer_size_ < 1 * MB) {

+ if (buffer_size_ < 1 * MB) {

desc.buffer_size = 2 * buffer_size_;

} else {

desc.buffer_size = buffer_size_ + 1 * MB;

« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/assembler.cc » ('j') | no next file with comments »