Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 446823002: Revert 287732 "<webview>: Move autosize from content to chrome." (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme
Modified:
6 years, 4 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 287732 "<webview>: Move autosize from content to chrome." The AutoSize test was failing on Mac: WebViewTest.AutoSize (run #1): [ RUN ] WebViewTest.AutoSize [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors [9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors [9340:71171:0806/013455:INFO:CONSOLE(14)] "guest.loadstop", source: chrome-extension://blepeeghknicglkaidbjijdlejjompdl/main.js (14) ASSERTION FAILED: !enable || !minSize.isEmpty() (log: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/26134/steps/browser_tests/logs/AutoSize) > <webview>: Move autosize from content to chrome. > > BUG=330264 > TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json > > Review URL: https://codereview.chromium.org/427883002 TBR=fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -369 lines) Patch
M trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.h View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/guest_view_base.h View 5 chunks +0 lines, -46 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/guest_view_base.cc View 5 chunks +0 lines, -56 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h View 4 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc View 5 chunks +17 lines, -45 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/guest_view_internal.json View 2 chunks +0 lines, -45 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/web_view.js View 8 chunks +12 lines, -63 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/web_view_events.js View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.h View 3 chunks +11 lines, -2 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc View 10 chunks +65 lines, -10 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/common/browser_plugin/browser_plugin_constants.h View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/content/common/browser_plugin/browser_plugin_constants.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/content/common/browser_plugin/browser_plugin_messages.h View 3 chunks +15 lines, -0 lines 0 comments Download
M trunk/src/content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +3 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin.h View 4 chunks +43 lines, -1 line 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin.cc View 7 chunks +159 lines, -14 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc View 3 chunks +162 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/browser_plugin/browser_plugin_browsertest.cc View 3 chunks +104 lines, -0 lines 0 comments Download
M trunk/src/extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-06 10:07:21 UTC) #1
tommi (sloooow) - chröme
6 years, 4 months ago (2014-08-06 10:07:33 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r287746 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698