Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 427883002: <webview>: Move autosize from content to chrome (Closed)

Created:
6 years, 4 months ago by Fady Samuel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_frame_url
Project:
chromium
Visibility:
Public.

Description

<webview>: Move autosize from content to chrome. BUG=330264 TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287732 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287822

Patch Set 1 #

Patch Set 2 : Works #

Total comments: 8

Patch Set 3 : Fixed race #

Patch Set 4 : Removed render_view_ready #

Patch Set 5 : Moved core autosize code to GuestViewBase #

Patch Set 6 : All tests #

Patch Set 7 : Code cleanup #

Total comments: 4

Patch Set 8 : Addressed ericzeng's comments. AutoSize disabled by default though. #

Total comments: 6

Patch Set 9 : Addressed Istiaque's comments #

Patch Set 10 : Updated histograms.xml #

Total comments: 1

Patch Set 11 : Rebased #

Patch Set 12 : Removed unnecessary content test #

Patch Set 13 : Removed unnecessary autosize test #

Patch Set 14 : Only enable if minsize > 0 #

Patch Set 15 : Initialize variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -618 lines) Patch
M chrome/browser/extensions/api/guest_view/guest_view_internal_api.h View 1 2 3 4 5 6 7 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc View 1 2 3 4 5 6 7 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.h View 1 2 3 4 5 6 7 8 5 chunks +46 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_constants.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_constants.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.h View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 5 chunks +45 lines, -17 lines 0 comments Download
M chrome/common/extensions/api/guest_view_internal.json View 1 2 3 4 5 6 7 2 chunks +45 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 1 2 3 4 5 6 7 8 9 10 8 chunks +63 lines, -12 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view_events.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 3 chunks +2 lines, -11 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 4 5 10 chunks +10 lines, -65 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 3 chunks +0 lines, -15 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 1 chunk +9 lines, -3 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 4 chunks +1 line, -43 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 7 chunks +14 lines, -159 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_bindings.cc View 3 chunks +0 lines, -162 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +0 lines, -104 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Fady Samuel
6 years, 4 months ago (2014-07-31 01:58:31 UTC) #1
lazyboy
https://chromiumcodereview.appspot.com/427883002/diff/20001/chrome/browser/guest_view/web_view/web_view_guest.cc File chrome/browser/guest_view/web_view/web_view_guest.cc (right): https://chromiumcodereview.appspot.com/427883002/diff/20001/chrome/browser/guest_view/web_view/web_view_guest.cc#newcode304 chrome/browser/guest_view/web_view/web_view_guest.cc:304: extra_params()->GetInteger(webview::kAttributeMaxHeight, &max_height); Do we need to DCHECK if GetInteger() ...
6 years, 4 months ago (2014-07-31 04:24:22 UTC) #2
Fady Samuel
+ericzeng@ https://codereview.chromium.org/427883002/diff/20001/chrome/browser/guest_view/web_view/web_view_guest.cc File chrome/browser/guest_view/web_view/web_view_guest.cc (right): https://codereview.chromium.org/427883002/diff/20001/chrome/browser/guest_view/web_view/web_view_guest.cc#newcode304 chrome/browser/guest_view/web_view/web_view_guest.cc:304: extra_params()->GetInteger(webview::kAttributeMaxHeight, &max_height); On 2014/07/31 04:24:22, lazyboy wrote: > ...
6 years, 4 months ago (2014-08-01 18:12:53 UTC) #3
ericzeng
https://codereview.chromium.org/427883002/diff/120001/chrome/browser/extensions/api/web_view/web_view_internal_api.h File chrome/browser/extensions/api/web_view/web_view_internal_api.h (right): https://codereview.chromium.org/427883002/diff/120001/chrome/browser/extensions/api/web_view/web_view_internal_api.h#newcode375 chrome/browser/extensions/api/web_view/web_view_internal_api.h:375: Should this be made available in guest_view_internal_api? It removes ...
6 years, 4 months ago (2014-08-01 18:55:10 UTC) #4
Fady Samuel
PTAL. I've moved the javascript bindings to GuestViewInternal. For security reasons, I've made autosize disabled ...
6 years, 4 months ago (2014-08-01 20:06:13 UTC) #5
lazyboy
LGTM with nits. https://chromiumcodereview.appspot.com/427883002/diff/140001/chrome/browser/guest_view/guest_view_base.h File chrome/browser/guest_view/guest_view_base.h (right): https://chromiumcodereview.appspot.com/427883002/diff/140001/chrome/browser/guest_view/guest_view_base.h#newcode124 chrome/browser/guest_view/guest_view_base.h:124: virtual bool IsAutoSizeEnabled() const; This more ...
6 years, 4 months ago (2014-08-01 20:26:04 UTC) #6
ericzeng
lgtm
6 years, 4 months ago (2014-08-01 20:29:13 UTC) #7
Fady Samuel
+asvitkine@ for histograms +creis@ for render_view_host_impl https://chromiumcodereview.appspot.com/427883002/diff/140001/chrome/browser/guest_view/guest_view_base.h File chrome/browser/guest_view/guest_view_base.h (right): https://chromiumcodereview.appspot.com/427883002/diff/140001/chrome/browser/guest_view/guest_view_base.h#newcode124 chrome/browser/guest_view/guest_view_base.h:124: virtual bool IsAutoSizeEnabled() ...
6 years, 4 months ago (2014-08-01 20:44:41 UTC) #8
Alexei Svitkine (slow)
lgtm for histograms
6 years, 4 months ago (2014-08-01 20:45:31 UTC) #9
Fady Samuel
https://codereview.chromium.org/427883002/diff/180001/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (right): https://codereview.chromium.org/427883002/diff/180001/content/browser/renderer_host/render_view_host_impl.cc#newcode1473 content/browser/renderer_host/render_view_host_impl.cc:1473: GetView()->SetSize(new_size); This ensures that the view is resized when ...
6 years, 4 months ago (2014-08-05 14:32:55 UTC) #10
Charlie Reis
Rubber stamp LGTM for render_view_host_impl.cc. (Sorry, I was out the last few days.)
6 years, 4 months ago (2014-08-05 17:04:15 UTC) #11
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-05 17:07:19 UTC) #12
Fady Samuel
The CQ bit was unchecked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-05 17:07:20 UTC) #13
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-05 17:07:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/427883002/220001
6 years, 4 months ago (2014-08-05 17:09:35 UTC) #15
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-05 22:08:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/427883002/240001
6 years, 4 months ago (2014-08-05 22:11:34 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-06 06:57:43 UTC) #18
commit-bot: I haz the power
Change committed as 287732
6 years, 4 months ago (2014-08-06 07:45:23 UTC) #19
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-06 15:09:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/427883002/260001
6 years, 4 months ago (2014-08-06 15:11:01 UTC) #21
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-06 15:15:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/427883002/280001
6 years, 4 months ago (2014-08-06 15:16:48 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 19:10:13 UTC) #24
Message was sent while issue was closed. 
Change committed as 287822

Powered by Google App Engine
This is Rietveld 408576698