Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 446673004: Hack in order to fix crbug.com/394672 in M38 (Closed)

Created:
6 years, 4 months ago by pkotwicz
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank, ananta
Project:
chromium
Visibility:
Public.

Description

Hack in order to fix crbug.com/394672 in M38 This CL effectively reverts https://codereview.chromium.org/344793013 for Windows only. BUG=394672 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288007

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/aura/window_event_dispatcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
Scott, PTAL This CL is a hack in order to fix crbug.com/382421 for M38. I ...
6 years, 4 months ago (2014-08-06 15:33:15 UTC) #1
sky
https://codereview.chromium.org/446673004/diff/20001/ui/aura/window_event_dispatcher.cc File ui/aura/window_event_dispatcher.cc (right): https://codereview.chromium.org/446673004/diff/20001/ui/aura/window_event_dispatcher.cc#newcode393 ui/aura/window_event_dispatcher.cc:393: #if !defined(OS_WIN) I'm pretty sure this code was added ...
6 years, 4 months ago (2014-08-06 18:01:32 UTC) #2
pkotwicz
https://codereview.chromium.org/446673004/diff/20001/ui/aura/window_event_dispatcher.cc File ui/aura/window_event_dispatcher.cc (right): https://codereview.chromium.org/446673004/diff/20001/ui/aura/window_event_dispatcher.cc#newcode393 ui/aura/window_event_dispatcher.cc:393: #if !defined(OS_WIN) The code was added for Linux. I ...
6 years, 4 months ago (2014-08-06 18:51:44 UTC) #3
sky
My mistake, LGTM
6 years, 4 months ago (2014-08-06 21:16:25 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-08-06 21:41:22 UTC) #5
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 4 months ago (2014-08-06 21:41:36 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-08-07 03:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/446673004/40001
6 years, 4 months ago (2014-08-07 03:27:46 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 08:11:16 UTC) #9
Message was sent while issue was closed. 
Change committed as 288007

Powered by Google App Engine
This is Rietveld 408576698