Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 344793013: Dispatch a synthetic mouse exit to the widget handling mouse events when a widget grabs capture (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tfarina, kalyank, ben+aura_chromium.org, ben+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Dispatch a synthetic ui::ET_MOUSE_EXITED event to the widget handling mouse events when a different widget grabs capture. This CL fixes the following scenario: - An event handler sets some state as a result of the widget getting hovered. - A different widget than the one handling mouse events grabs capture. (e.g. the menu) Sending a ui::ET_MOUSE_EXITED event is necessary so that any state set as a result of the widget getting hovered is reset. In particular, ui::ET_MOUSE_CAPTURE_CHANGED is not dispatched in this scenario. BUG=382421 TEST=WidgetCaptureTest.MouseExitOnCaptureGrab Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280072

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M ui/aura/window_event_dispatcher.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 3 chunks +18 lines, -7 lines 2 comments Download
M ui/aura/window_tree_host.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 3 chunks +42 lines, -1 line 1 comment Download

Messages

Total messages: 13 (0 generated)
sky
Sadrul is a better reviewer than I for this.
6 years, 6 months ago (2014-06-23 20:39:52 UTC) #1
sadrul
There are some subtle changes on when exit/move events are sent in this CL. I ...
6 years, 6 months ago (2014-06-24 18:33:09 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-24 21:18:43 UTC) #3
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-24 21:18:44 UTC) #4
pkotwicz
Sadrul, can you please take a look? - I have fixed WidgetCaptureTest.MouseExitOnCaptureGrab so that it ...
6 years, 6 months ago (2014-06-25 15:16:35 UTC) #5
sadrul
LGTM https://codereview.chromium.org/344793013/diff/180001/ui/aura/window_event_dispatcher.cc File ui/aura/window_event_dispatcher.cc (right): https://codereview.chromium.org/344793013/diff/180001/ui/aura/window_event_dispatcher.cc#newcode205 ui/aura/window_event_dispatcher.cc:205: mouse_pressed_handler_ = NULL; Is it necessary to make ...
6 years, 6 months ago (2014-06-26 12:59:35 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-26 14:45:11 UTC) #7
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-26 14:45:14 UTC) #8
pkotwicz
https://codereview.chromium.org/344793013/diff/180001/ui/aura/window_event_dispatcher.cc File ui/aura/window_event_dispatcher.cc (right): https://codereview.chromium.org/344793013/diff/180001/ui/aura/window_event_dispatcher.cc#newcode205 ui/aura/window_event_dispatcher.cc:205: mouse_pressed_handler_ = NULL; I need to investigate why OnHostLostMouseGrab() ...
6 years, 6 months ago (2014-06-26 14:45:18 UTC) #9
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-26 14:45:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/344793013/180001
6 years, 6 months ago (2014-06-26 14:47:15 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 18:00:09 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 19:30:57 UTC) #13
Message was sent while issue was closed.
Change committed as 280072

Powered by Google App Engine
This is Rietveld 408576698