slave/skia_slave_scripts/compare_rendered_skps.py - Issue 446373003: adjust prefetch URL we hit in UploadRenderedSKPs, and display view URL in CompareRenderedSKPs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/compare_rendered_skps.py

Issue 446373003: adjust prefetch URL we hit in UploadRenderedSKPs, and display view URL in CompareRenderedSKPs (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: slave/skia_slave_scripts/compare_rendered_skps.py

diff --git a/slave/skia_slave_scripts/compare_rendered_skps.py b/slave/skia_slave_scripts/compare_rendered_skps.py

index cf03e6f90d6bcd0fc28d77973ac0333b80ab2ea2..bf9b81faf852347148c90463c32fbe7df3a5efee 100644

--- a/slave/skia_slave_scripts/compare_rendered_skps.py

+++ b/slave/skia_slave_scripts/compare_rendered_skps.py

@@ -9,12 +9,18 @@

import sys

from build_step import BuildStep

+import upload_rendered_skps

class CompareRenderedSKPs(BuildStep):

def _Run(self):

- print 'TODO(epoger): Not yet implemented; see http://skbug.com/1942'

+ print ('To view the latest SKP renderings by this builder, see:\n%s' %

+ upload_rendered_skps.rebaseline_server_url(

+ directive='static/live-view.html#/live-view.html?',

+ builder_name=self._args['builder_name']))

borenet 2014/08/07 19:00:24 I think you should be able to just do self._builde

epoger 2014/08/07 19:09:08 Yup, I verified that it works. Thanks.

+ print ''

+ print 'TODO(epoger): Compare not yet implemented; see http://skbug.com/1942'

if '__main__' == __name__:

« no previous file with comments | « no previous file | slave/skia_slave_scripts/upload_rendered_skps.py » ('j') | no next file with comments »