Chromium Code Reviews Chromium Code Reviews
Issue 446373003:
adjust prefetch URL we hit in UploadRenderedSKPs, and display view URL in CompareRenderedSKPs (Closed)
Base URL: https://skia.googlesource.com/buildbot.git@master| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # Copyright (c) 2014 The Chromium Authors. All rights reserved. | 2 # Copyright (c) 2014 The Chromium Authors. All rights reserved. |
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
| 5 | 5 |
| 6 """Compares the results of render_skps.py against expectations. | 6 """Compares the results of render_skps.py against expectations. |
| 7 """ | 7 """ |
| 8 | 8 |
| 9 import sys | 9 import sys |
| 10 | 10 |
| 11 from build_step import BuildStep | 11 from build_step import BuildStep |
| 12 import upload_rendered_skps | |
| 12 | 13 |
| 13 | 14 |
| 14 class CompareRenderedSKPs(BuildStep): | 15 class CompareRenderedSKPs(BuildStep): |
| 15 | 16 |
| 16 def _Run(self): | 17 def _Run(self): |
| 17 print 'TODO(epoger): Not yet implemented; see http://skbug.com/1942' | 18 print ('To view the latest SKP renderings by this builder, see:\n%s' % |
| 19 upload_rendered_skps.rebaseline_server_url( | |
| 20 directive='static/live-view.html#/live-view.html?', | |
| 21 builder_name=self._args['builder_name'])) | |
|
borenet
2014/08/07 19:00:24
I think you should be able to just do self._builde
epoger
2014/08/07 19:09:08
Yup, I verified that it works. Thanks.
| |
| 22 print '' | |
| 23 print 'TODO(epoger): Compare not yet implemented; see http://skbug.com/1942' | |
| 18 | 24 |
| 19 | 25 |
| 20 if '__main__' == __name__: | 26 if '__main__' == __name__: |
| 21 sys.exit(BuildStep.RunBuildStep(CompareRenderedSKPs)) | 27 sys.exit(BuildStep.RunBuildStep(CompareRenderedSKPs)) |
| OLD | NEW |
