Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 446373003: adjust prefetch URL we hit in UploadRenderedSKPs, and display view URL in CompareRenderedSKPs (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org, stephana, rmistry
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

adjust prefetch URL we hit in UploadRenderedSKPs, and display view URL in CompareRenderedSKPs This goes along with https://codereview.chromium.org/453433004/ ('rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS') For full context, see https://goto.google.com/CorrectnessTestingBigIssues BUG=skia:1942 Committed: https://skia.googlesource.com/buildbot/+/ffbf5dc933305280bc84a621556eb593a0e80c5f

Patch Set 1 #

Total comments: 2

Patch Set 2 : self._builder_name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M slave/skia_slave_scripts/compare_rendered_skps.py View 1 1 chunk +7 lines, -1 line 0 comments Download
M slave/skia_slave_scripts/upload_rendered_skps.py View 1 3 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Eric, PTAL as of patchset 1. It works in my local testing.
6 years, 4 months ago (2014-08-07 18:51:13 UTC) #1
borenet
LGTM https://codereview.chromium.org/446373003/diff/1/slave/skia_slave_scripts/compare_rendered_skps.py File slave/skia_slave_scripts/compare_rendered_skps.py (right): https://codereview.chromium.org/446373003/diff/1/slave/skia_slave_scripts/compare_rendered_skps.py#newcode21 slave/skia_slave_scripts/compare_rendered_skps.py:21: builder_name=self._args['builder_name'])) I think you should be able to ...
6 years, 4 months ago (2014-08-07 19:00:24 UTC) #2
epoger
Committing now. https://codereview.chromium.org/446373003/diff/1/slave/skia_slave_scripts/compare_rendered_skps.py File slave/skia_slave_scripts/compare_rendered_skps.py (right): https://codereview.chromium.org/446373003/diff/1/slave/skia_slave_scripts/compare_rendered_skps.py#newcode21 slave/skia_slave_scripts/compare_rendered_skps.py:21: builder_name=self._args['builder_name'])) On 2014/08/07 19:00:24, borenet wrote: > ...
6 years, 4 months ago (2014-08-07 19:09:08 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-07 19:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/446373003/20001
6 years, 4 months ago (2014-08-07 19:10:57 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 19:11:19 UTC) #6
Message was sent while issue was closed.
Change committed as ffbf5dc933305280bc84a621556eb593a0e80c5f

Powered by Google App Engine
This is Rietveld 408576698