Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 446063007: Rename NoEventDispatchAssertion to EventDispatchForbiddenScope and move it to platform/ (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr., rwlbuis, Stephen Chennney, sof, webcomponents-bugzilla_chromium.org
Project:
blink
Visibility:
Public.

Description

Rename NoEventDispatchAssertion to EventDispatchForbiddenScope and move it to platform/ This is for consistency with ScriptForbiddenScope, which is often used with EventDispatchForbiddenScope. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -120 lines) Patch
M Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 14 chunks +13 lines, -13 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D Source/core/dom/NoEventDispatchAssertion.h View 1 chunk +0 lines, -74 lines 0 comments Download
M Source/core/dom/Node.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/UndoStack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/EventDispatcher.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
A + Source/platform/EventDispatchForbiddenScope.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-07 09:35:42 UTC) #1
haraken
Elliott: friendly ping?
6 years, 4 months ago (2014-08-11 11:50:31 UTC) #2
haraken
Elliott: Would you take a look at this? This is a simple follow-up CL for ...
6 years, 4 months ago (2014-08-13 23:26:28 UTC) #3
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 4 months ago (2014-08-14 00:43:08 UTC) #4
esprehn
lgtm
6 years, 4 months ago (2014-08-14 00:43:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/446063007/1
6 years, 4 months ago (2014-08-14 00:44:31 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 05:18:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180236

Powered by Google App Engine
This is Rietveld 408576698