Issue 446063005: Move Quic AppendTimestampFrame method out of AppendCongestionFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 446063005: Move Quic AppendTimestampFrame method out of AppendCongestionFrame. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett, cyr_google.com, wtc

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move Quic AppendTimestampFrame method out of AppendCongestionFrame. Also, remove obsolete TODO's and rename InterArrival to Timestamp. Not used in production. Merge internal change: 72148809 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+291 lines, -287 lines)			Patch
M	net/quic/congestion_control/hybrid_slow_start_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/congestion_control/receive_algorithm_interface.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/crypto/crypto_protocol.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_config_test.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/quic_connection_logger.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	net/quic/quic_framer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_framer.cc	View	8 chunks	+250 lines, -247 lines	0 comments	Download
M	net/quic/quic_framer_test.cc	View	7 chunks	+12 lines, -12 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/quic/quic_protocol.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	net/quic/test_tools/mock_crypto_client_stream.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages