Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: net/quic/congestion_control/hybrid_slow_start_test.cc

Issue 446063005: Move Quic AppendTimestampFrame method out of AppendCongestionFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/congestion_control/receive_algorithm_interface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "net/quic/congestion_control/hybrid_slow_start.h" 7 #include "net/quic/congestion_control/hybrid_slow_start.h"
8 #include "net/quic/test_tools/mock_clock.h" 8 #include "net/quic/test_tools/mock_clock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 slow_start_->StartReceiveRound(end_sequence_number); 46 slow_start_->StartReceiveRound(end_sequence_number);
47 while (sequence_number < end_sequence_number) { 47 while (sequence_number < end_sequence_number) {
48 EXPECT_FALSE(slow_start_->IsEndOfRound(sequence_number++)); 48 EXPECT_FALSE(slow_start_->IsEndOfRound(sequence_number++));
49 } 49 }
50 EXPECT_TRUE(slow_start_->IsEndOfRound(sequence_number++)); 50 EXPECT_TRUE(slow_start_->IsEndOfRound(sequence_number++));
51 } 51 }
52 52
53 // TODO(ianswett): Add tests which more realistically invoke the methods, 53 // TODO(ianswett): Add tests which more realistically invoke the methods,
54 // simulating how actual acks arrive and packets are sent. 54 // simulating how actual acks arrive and packets are sent.
55 TEST_F(HybridSlowStartTest, AckTrain) { 55 TEST_F(HybridSlowStartTest, AckTrain) {
56 // At a typical RTT 60 ms, assuming that the inter arrival is 1 ms, 56 // At a typical RTT 60 ms, assuming that the inter arrival timestamp is 1 ms,
57 // we expect to be able to send a burst of 30 packet before we trigger the 57 // we expect to be able to send a burst of 30 packet before we trigger the
58 // ack train detection. 58 // ack train detection.
59 const int kMaxLoopCount = 5; 59 const int kMaxLoopCount = 5;
60 QuicPacketSequenceNumber sequence_number = 2; 60 QuicPacketSequenceNumber sequence_number = 2;
61 QuicPacketSequenceNumber end_sequence_number = 2; 61 QuicPacketSequenceNumber end_sequence_number = 2;
62 for (int burst = 0; burst < kMaxLoopCount; ++burst) { 62 for (int burst = 0; burst < kMaxLoopCount; ++burst) {
63 slow_start_->StartReceiveRound(end_sequence_number); 63 slow_start_->StartReceiveRound(end_sequence_number);
64 do { 64 do {
65 clock_.AdvanceTime(one_ms_); 65 clock_.AdvanceTime(one_ms_);
66 EXPECT_FALSE(slow_start_->ShouldExitSlowStart(rtt_, rtt_, 100)); 66 EXPECT_FALSE(slow_start_->ShouldExitSlowStart(rtt_, rtt_, 100));
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 rtt_.Add(QuicTime::Delta::FromMilliseconds(n + 5)), rtt_, 100)); 98 rtt_.Add(QuicTime::Delta::FromMilliseconds(n + 5)), rtt_, 100));
99 } 99 }
100 // Expect to trigger since all packets in this burst was above the long term 100 // Expect to trigger since all packets in this burst was above the long term
101 // RTT provided. 101 // RTT provided.
102 EXPECT_TRUE(slow_start_->ShouldExitSlowStart( 102 EXPECT_TRUE(slow_start_->ShouldExitSlowStart(
103 rtt_.Add(QuicTime::Delta::FromMilliseconds(5)), rtt_, 100)); 103 rtt_.Add(QuicTime::Delta::FromMilliseconds(5)), rtt_, 100));
104 } 104 }
105 105
106 } // namespace test 106 } // namespace test
107 } // namespace net 107 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/congestion_control/receive_algorithm_interface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698