Issue 445933003: Clean up testing.internals argument type checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 445933003: Clean up testing.internals argument type checking. (Closed)

Created:
6 years, 4 months ago by sof

Modified:
6 years, 4 months ago

Reviewers:
haraken, jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Clean up testing.internals argument type checking. Make use of [TypeChecking=Interface] where possible, fixing null pointer deref over internals.addTextMatchMarker in the process. R=haraken@chromium.org BUG=375712 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179706

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+330 lines, -448 lines)			Patch
M	LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/testing/Internals.h	View	1	8 chunks	+40 lines, -40 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	1	61 chunks	+199 lines, -310 lines	0 comments	Download
M	Source/core/testing/Internals.idl	View	1	10 chunks	+88 lines, -88 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/445933003/20001

6 years, 4 months ago (2014-08-07 12:30:01 UTC) #4

Message was sent while issue was closed.

Change committed as 179706