Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html

Issue 445933003: Clean up testing.internals argument type checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Tidy up result type Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html
diff --git a/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html b/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html
index 3cb562baa01beb9f41e623d8eb2b86c54b099cc3..aed236bdd1fdc688e554abd053322597fe4f0c24 100644
--- a/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html
+++ b/LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow.html
@@ -17,15 +17,8 @@ if (window.internals) {
var shadow = internals.shadowRoot(keygen);
shouldBe('shadow.nodeName', '"#document-fragment"');
- // Shadow roots aren't elements, so accessing their shadow should
- // raise
- var exceptionCode;
- try {
- internals.shadowRoot(shadow);
- } catch (e) {
- exceptionCode = e.code;
- }
- shouldBe('exceptionCode', 'DOMException.INVALID_ACCESS_ERR');
+ // Shadow roots aren't elements, so accessing their shadow should throw.
+ shouldThrow("internals.shadowRoot(shadow)");
// Ordinary element should not have shadow
var p = document.getElementById('peas');
« no previous file with comments | « no previous file | LayoutTests/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698