Enabling Commands API for Apps

chrome/common/extensions/command.cc

Index: chrome/common/extensions/command.cc
diff --git a/chrome/common/extensions/command.cc b/chrome/common/extensions/command.cc
index a1216abe8eabbc67773b38e16971509f16a7cfe4..5dbb96df0e0466598f772a88f11063e20c712737 100644
--- a/chrome/common/extensions/command.cc
+++ b/chrome/common/extensions/command.cc
@@ -438,7 +438,9 @@ bool Command::Parse(const base::DictionaryValue* command,
 
   // Check if this is a global or a regular shortcut.
   bool global = false;
-  command->GetBoolean(keys::kGlobal, &global);
+  if (FeatureSwitch::global_commands()->IsEnabled() &&
+      chrome::VersionInfo::GetChannel() <= chrome::VersionInfo::CHANNEL_DEV)

[Yoyo Zhou, 2013/10/30 17:02:48]

This channel check should not be necessary. It looks like the reason "global" is
still appearing in the dictionary in stable is:

Manifest::GetDictionary("commands") checks that we have access to the "commands"
feature and returns the whole "commands" dictionary, including the "global" key.

Manifest::GetBoolean("commands.global") would check that we have access to the
"commands.global" feature, and return nothing.

You'd have to pass Manifest into this Parse function instead of just the
DictionaryValue for "commands".

+    command->GetBoolean(keys::kGlobal, &global);
 
   // Normalize the suggestions.
   for (SuggestionMap::iterator iter = suggestions.begin();