Enabling Commands API for Apps

chrome/common/extensions/command.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/command.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
@@ skipping 420 matching lines @@
         !suggested_key_string.empty()) {
       // If only a single string is provided, it must be default for all.
       suggestions[values::kKeybindingPlatformDefault] = suggested_key_string;
     } else {
       suggestions[values::kKeybindingPlatformDefault] = "";
     }
   }
 
   // Check if this is a global or a regular shortcut.
   bool global = false;
-  command->GetBoolean(keys::kGlobal, &global);
+  if (FeatureSwitch::global_commands()->IsEnabled() &&
+      chrome::VersionInfo::GetChannel() <= chrome::VersionInfo::CHANNEL_DEV)

[Yoyo Zhou, 2013/10/30 17:02:48]

This channel check should not be necessary. It looks like the reason "global" is
still appearing in the dictionary in stable is:

Manifest::GetDictionary("commands") checks that we have access to the "commands"
feature and returns the whole "commands" dictionary, including the "global" key.

Manifest::GetBoolean("commands.global") would check that we have access to the
"commands.global" feature, and return nothing.

You'd have to pass Manifest into this Parse function instead of just the
DictionaryValue for "commands".

+    command->GetBoolean(keys::kGlobal, &global);
 
   // Normalize the suggestions.
   for (SuggestionMap::iterator iter = suggestions.begin();
        iter != suggestions.end(); ++iter) {
     // Before we normalize Ctrl to Command we must detect when the developer
     // specified Command in the Default section, which will work on Mac after
     // normalization but only fail on other platforms when they try it out on
     // other platforms, which is not what we want.
     if (iter->first == values::kKeybindingPlatformDefault &&
         iter->second.find("Command+") != std::string::npos) {
@@ skipping 84 matching lines @@
     // dev and will be removed when we launch.
     static bool stable_or_beta =
         chrome::VersionInfo::GetChannel() >= chrome::VersionInfo::CHANNEL_BETA;
     extension_data->SetBoolean("scope_ui_visible", !stable_or_beta);
   }
 
   return extension_data;
 }
 
 }  // namespace extensions