Enabling Commands API for Apps

chrome/common/extensions/api/_manifest_features.json

Index: chrome/common/extensions/api/_manifest_features.json
diff --git a/chrome/common/extensions/api/_manifest_features.json b/chrome/common/extensions/api/_manifest_features.json
index 3522585aabb09695501863d5e03a37683f42d55d..ae5a8e20140cf2fa752b1e9daf4cf04cdf646b77 100644
--- a/chrome/common/extensions/api/_manifest_features.json
+++ b/chrome/common/extensions/api/_manifest_features.json
@@ -79,16 +79,28 @@
     "channel": "stable",
     "extension_types": ["extension", "legacy_packaged_app"]
   },
-  "commands": {
-    "channel": "stable",
-    "extension_types": ["extension"],
-    "min_manifest_version": 2
-  },
-  "commands.global": {
-    "channel": "dev",
-    "extension_types": ["extension"],
-    "min_manifest_version": 2
-  },
+  "commands": [
+    {
+      "channel": "dev",
+      "extension_types": ["extension", "platform_app"],

[not at google - send to devlin, 2013/10/28 16:17:22]

You shouldn't need the "extension" here. These lists of features are an OR op,
whereas each rule within a feature is an AND.

[Finnur, 2013/10/28 16:34:24]

Changed.

To be clear -- because "extension" features on "stable", I don't need to specify
it also for "dev"? 

[not at google - send to devlin, 2013/10/28 16:41:32]

Yes exactly.

+      "min_manifest_version": 2
+    }, {
+      "channel": "stable",
+      "extension_types": ["extension"],
+      "min_manifest_version": 2
+    }
+  ],
+  "commands.global": [
+    {
+      "channel": "dev",
+      "extension_types": ["extension", "platform_app"],
+      "min_manifest_version": 2
+    }, {
+      "channel": "stable",
+      "extension_types": [],
+      "min_manifest_version": 2

[not at google - send to devlin, 2013/10/28 16:17:22]

So you need this rule to balance the one above for some reason?

[Finnur, 2013/10/28 16:34:24]

Yes. This makes the CHECK go away.

[not at google - send to devlin, 2013/10/28 16:41:32]

Huh. Which CHECK?

+    }
+  ],
   "content_pack": {
     "channel": "dev",
     "extension_types": ["extension"]