Enabling Commands API for Apps

chrome/common/extensions/api/_manifest_features.json

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See c/c/e/features/* to understand this file, in particular feature.h,
 // simple_feature.h, and base_feature_provider.h.
 
 {
   "app": {
     "channel": "stable",
@@ skipping 61 matching lines @@
     "extension_types": ["extension"]
   },
   "chrome_settings_overrides": {
     "channel": "dev",
     "extension_types": ["extension"]
   },
   "chrome_url_overrides": {
     "channel": "stable",
     "extension_types": ["extension", "legacy_packaged_app"]
   },
-  "commands": {
-    "channel": "stable",
-    "extension_types": ["extension"],
-    "min_manifest_version": 2
-  },
-  "commands.global": {
-    "channel": "dev",
-    "extension_types": ["extension"],
-    "min_manifest_version": 2
-  },
+  "commands": [
+    {
+      "channel": "dev",
+      "extension_types": ["extension", "platform_app"],

[not at google - send to devlin, 2013/10/28 16:17:22]

You shouldn't need the "extension" here. These lists of features are an OR op,
whereas each rule within a feature is an AND.

[Finnur, 2013/10/28 16:34:24]

Changed.

To be clear -- because "extension" features on "stable", I don't need to specify
it also for "dev"? 

[not at google - send to devlin, 2013/10/28 16:41:32]

Yes exactly.

+      "min_manifest_version": 2
+    }, {
+      "channel": "stable",
+      "extension_types": ["extension"],
+      "min_manifest_version": 2
+    }
+  ],
+  "commands.global": [
+    {
+      "channel": "dev",
+      "extension_types": ["extension", "platform_app"],
+      "min_manifest_version": 2
+    }, {
+      "channel": "stable",
+      "extension_types": [],
+      "min_manifest_version": 2

[not at google - send to devlin, 2013/10/28 16:17:22]

So you need this rule to balance the one above for some reason?

[Finnur, 2013/10/28 16:34:24]

Yes. This makes the CHECK go away.

[not at google - send to devlin, 2013/10/28 16:41:32]

Huh. Which CHECK?

+    }
+  ],
   "content_pack": {
     "channel": "dev",
     "extension_types": ["extension"]
   },
   "content_security_policy": {
     "channel": "stable",
     // Platform apps have a restricted content security policy that cannot be
     // overriden (except for a whitelist of exceptions, see the
     // app.content_security_policy whitelist).
     "extension_types": ["extension", "legacy_packaged_app"]
@@ skipping 292 matching lines @@
     "extension_types": [
       "extension", "legacy_packaged_app", "hosted_app"
     ]
   },
   "webview": {
     "channel": "dev",
     "extension_types": ["platform_app"],
     "min_manifest_version": 2
   }
 }