Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 445503004: Dismiss multiple error dialogs when running tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index 0fba7e7602c54de55a0896c9470adcc9577d3b6b..19e86d96fbccec4a1293e268c14b253c524b573f 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -273,7 +273,8 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
# If we have no existing tabs start with a blank page since default
# startup with the NTP can lead to race conditions with Telemetry
url = 'about:blank'
- self._adb.device().old_interface.DismissCrashDialogIfNeeded()
+ while self._adb.device().old_interface.DismissCrashDialogIfNeeded():
Peter Beverloo 2014/08/05 14:03:44 I'm a bit wary of using this in a (potentially end
aberent 2014/08/05 14:28:54 Already fixed. See patch set 3.
+ pass
self._adb.device().StartActivity(
intent.Intent(package=self._backend_settings.package,
activity=self._backend_settings.activity,

Powered by Google App Engine
This is Rietveld 408576698