Dismiss multiple error dialogs when running tests

build/android/pylib/instrumentation/test_runner.py

Index: build/android/pylib/instrumentation/test_runner.py
diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py
index 3f9ac68511dfc3475c86e4f1c7ffdc6f67023e57..1c173eabea3c15a69a16f905295f2e48a42b9605 100644
--- a/build/android/pylib/instrumentation/test_runner.py
+++ b/build/android/pylib/instrumentation/test_runner.py
@@ -393,9 +393,14 @@ class TestRunner(base_test_runner.BaseTestRunner):
           log = 'No information.'
         result_type = base_test_result.ResultType.FAIL
         package = self.device.old_interface.DismissCrashDialogIfNeeded()
-        # Assume test package convention of ".test" suffix
-        if package and package in self.test_pkg.GetPackageName():
-          result_type = base_test_result.ResultType.CRASH
+        for _ in xrange(10):

[Peter Beverloo, 2014/08/05 14:03:43]

10 is an arbitrary number I imagine? It would be good to capture that in a
comment.

[aberent, 2014/08/05 14:28:54]

Already fixed. See patch set 3.

+          if not package:
+            break
+          # Assume test package convention of ".test" suffix
+          if package in self.test_pkg.GetPackageName():
+            result_type = base_test_result.ResultType.CRASH
+            break
+          package = self.device.old_interface.DismissCrashDialogIfNeeded()
         result = test_result.InstrumentationTestResult(
             test, result_type, start_date_ms, duration_ms, log=log)
       else: