Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/modules/webaudio/AudioNodeInput.h

Issue 445453006: Add comments to vectors/hash sets of raw pointers to on-heap objects used in webaudio/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webaudio/AudioContext.h ('k') | Source/modules/webaudio/AudioSummingJunction.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 unsigned numberOfChannels() const; 80 unsigned numberOfChannels() const;
81 81
82 private: 82 private:
83 explicit AudioNodeInput(AudioNode&); 83 explicit AudioNodeInput(AudioNode&);
84 84
85 RawPtrWillBeMember<AudioNode> m_node; 85 RawPtrWillBeMember<AudioNode> m_node;
86 86
87 // m_disabledOutputs contains the AudioNodeOutputs which are disabled (will not be processed) by the audio graph rendering. 87 // m_disabledOutputs contains the AudioNodeOutputs which are disabled (will not be processed) by the audio graph rendering.
88 // But, from JavaScript's perspective, these outputs are still connected to us. 88 // But, from JavaScript's perspective, these outputs are still connected to us.
89 // Generally, these represent disabled connections from "notes" which have f inished playing but are not yet garbage collected. 89 // Generally, these represent disabled connections from "notes" which have f inished playing but are not yet garbage collected.
90 // Oilpan: Since items are added to the hash set by the audio thread (not re gistered to Oilpan),
91 // we cannot use a HeapHashSet.
90 HashSet<AudioNodeOutput*> m_disabledOutputs; 92 HashSet<AudioNodeOutput*> m_disabledOutputs;
91 93
92 // Called from context's audio thread. 94 // Called from context's audio thread.
93 AudioBus* internalSummingBus(); 95 AudioBus* internalSummingBus();
94 void sumAllConnections(AudioBus* summingBus, size_t framesToProcess); 96 void sumAllConnections(AudioBus* summingBus, size_t framesToProcess);
95 97
96 RefPtr<AudioBus> m_internalSummingBus; 98 RefPtr<AudioBus> m_internalSummingBus;
97 }; 99 };
98 100
99 } // namespace blink 101 } // namespace blink
100 102
101 #endif // AudioNodeInput_h 103 #endif // AudioNodeInput_h
OLDNEW
« no previous file with comments | « Source/modules/webaudio/AudioContext.h ('k') | Source/modules/webaudio/AudioSummingJunction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698