Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller.h

Issue 44543002: Enable touch for autofill popup view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed Gtk and Cocoa compile errors Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller.h b/chrome/browser/ui/autofill/autofill_popup_controller.h
index 4b4f7c6d8f540ce1d031f13100dc8f35b77504df..6e3e2cac4c84481a8c1cdd99b76f10a71857a345 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller.h
@@ -36,14 +36,14 @@ class AutofillPopupController {
// Recalculates the height and width of the popup and triggers a redraw.
virtual void UpdateBoundsAndRedrawPopup() = 0;
- // The user has moved the mouse within the popup.
- virtual void MouseHovered(int x, int y) = 0;
+ // The line at (x, y) is preselected (e.g., mouse hovered).
+ virtual void PointPreselected(int x, int y) = 0;
Ilya Sherman 2013/11/01 06:45:50 It doesn't make sense, at least in terminology tha
- // The user clicked the mouse within the popup.
- virtual void MouseClicked(int x, int y) = 0;
+ // The line at (x, y) is selected (e.g., mouse clicked).
+ virtual void PointSelected(int x, int y) = 0;
- // The user has moved the mouse outside of the popup.
- virtual void MouseExitedPopup() = 0;
+ // The preselection is cleared (e.g., mouse exited popup).
+ virtual void PreselectionCleared() = 0;
// Whether |event| should be reposted to the native window management.
virtual bool ShouldRepostEvent(const ui::MouseEvent& event) = 0;
@@ -103,9 +103,9 @@ class AutofillPopupController {
virtual const gfx::Font& subtext_font() const = 0;
#endif
- // Returns the index of the selected line. A line is "selected" when it is
- // hovered or has keyboard focus.
- virtual int selected_line() const = 0;
+ // Returns the index of the preselected line. A line is "preselected" when it
+ // is hovered or has keyboard focus.
+ virtual int preselected_line() const = 0;
// Whether the view should be hidden on outside mouse presses.
virtual bool hide_on_outside_click() const = 0;

Powered by Google App Engine
This is Rietveld 408576698