components/autofill/core/browser/autofill_external_delegate.h - Issue 44543002: Enable touch for autofill popup view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 44543002: Enable touch for autofill popup view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed Gtk and Cocoa compile errors Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 0a0093e9ed1f732d0a2a99422b448f7605c5dd6a..5bf60a88300cb07667001ada040dfec281ed16cd 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -52,7 +52,7 @@ class AutofillExternalDelegate

virtual void OnPopupHidden(

content::RenderWidgetHost::KeyPressEventCallback* callback) OVERRIDE;

virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;

- virtual void DidSelectSuggestion(int identifier) OVERRIDE;

+ virtual void DidPreselectSuggestion(int identifier) OVERRIDE;

Ilya Sherman 2013/11/01 06:45:50 Please preserve the previous name, i.e. "select" r

virtual void DidAcceptSuggestion(const base::string16& value,

int identifier) OVERRIDE;

virtual void RemoveSuggestion(const base::string16& value,