Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 445303002: Change '>=' back to '>' in extension.h due to bad fix (Closed)

Created:
6 years, 4 months ago by jun_fang
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Change '>=' back to '>' in extension.h due to bad fix BUG=400662 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/df449c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M core/src/fxcrt/extension.h View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jun_fang
Hi Tom, please review this change.
6 years, 4 months ago (2014-08-07 04:35:18 UTC) #1
Tom Sepez
lgtm
6 years, 4 months ago (2014-08-07 16:32:10 UTC) #2
jun_fang
6 years, 4 months ago (2014-08-07 17:08:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as df449c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698