Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: core/src/fxcrt/extension.h

Issue 445303002: Change '>=' back to '>' in extension.h due to bad fix (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/extension.h
diff --git a/core/src/fxcrt/extension.h b/core/src/fxcrt/extension.h
index 6221d14fc7be9f711779ea1f6ea32738cb9ae65c..bb2a79b9f92ccae4e8ddc93119080750c9b9f238 100644
--- a/core/src/fxcrt/extension.h
+++ b/core/src/fxcrt/extension.h
@@ -73,7 +73,7 @@ public:
FX_SAFE_FILESIZE pos = size;
pos += offset;
- if (!pos.IsValid() || pos.ValueOrDie() >= m_pFile->GetSize()) {
+ if (!pos.IsValid() || pos.ValueOrDie() > m_pFile->GetSize()) {
return FALSE;
}
@@ -95,7 +95,7 @@ public:
if (m_bUseRange) {
pos += m_nOffset;
- if (!pos.IsValid() || pos.ValueOrDie() >= (size_t)GetSize()) {
+ if (!pos.IsValid() || pos.ValueOrDie() > (size_t)GetSize()) {
return FALSE;
}
}
@@ -200,7 +200,7 @@ public:
}
FX_SAFE_FILESIZE range = size;
range += offset;
- if (!range.IsValid() || range.ValueOrDie() >= m_nCurSize) {
+ if (!range.IsValid() || range.ValueOrDie() > m_nCurSize) {
return FALSE;
}
@@ -232,7 +232,7 @@ public:
FX_SAFE_SIZE_T newPos = size;
newPos += offset;
- if (!newPos.IsValid() || newPos.ValueOrDefault(0) == 0 || newPos.ValueOrDie() >= m_nCurSize) {
+ if (!newPos.IsValid() || newPos.ValueOrDefault(0) == 0 || newPos.ValueOrDie() > m_nCurSize) {
return FALSE;
}
« no previous file with comments | « no previous file | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698